[PATCH] D21114: [DebugInfo] Add calling convention support for DWARF and CodeView

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 10:12:42 PDT 2016


majnemer added inline comments.

================
Comment at: include/llvm/IR/DebugInfoMetadata.h:959
@@ -951,1 +958,3 @@
 
+  unsigned getCC() const { return CC; }
+
----------------
DebugInfoMetadata.h includes Dwarf.h, can we make this return an `enum CallingConvention`?

================
Comment at: include/llvm/Support/Dwarf.h:390
@@ -389,3 +389,3 @@
 
 enum CallingConvention {
   // Calling convention codes
----------------
Can we give this an underlying type of `uint8_t`?


http://reviews.llvm.org/D21114





More information about the llvm-commits mailing list