[PATCH] D21107: Generate codeview for array types

[Reid Kleckner via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm with nit


================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:788
@@ +787,3 @@
+  uint64_t Size = Ty->getSizeInBits() / 8;
+  ArrayRecord Record(ElementTypeIndex, IndexType, Size, Ty->getName());
+  return TypeTable.writeArray(Record);
----------------
Just commenting.

================
Comment at: test/DebugInfo/COFF/types-array.ll:85
@@ +84,3 @@
+; CHECK:   ]
+; CHECK:   Subsection [
+; CHECK:     SubSectionType: Lines (0xF2)
----------------
We can delete all the CHECK lines from here to the end, this is all line table info that should be covered elsewhere.


http://reviews.llvm.org/D21107