[llvm] r271925 - [MBP] Reduce code size by running tail merging in MBP.

[Renato Golin via llvm-commits]

On 8 June 2016 at 15:23, Haicheng Wu <haicheng at codeaurora.org> wrote:
> Do you think it is better for me to reapply r271925 but leave it turned off by default so that whoever tries to fix PR28049 does not need to rebase my reverted patch?

Hi Haicheng,

I don't think that's a good idea at all.

We normally only commit stuff disabled by default when it's a work in
progress and the missing bits are remaining features. This case is
completely orthogonal, as we found a bug and need to fix it.

I seriously discourage adding options to work around bugs, as whenever
someone turns it on by default again, we'll have the same problem.
Simply put, if the patch is good, we commit, if not we work until it
is.

Our "no regression" rule extend all the way to "don't add hacks to
hide regressions". :)

cheers,
--renato