[PATCH] D21090: [PM] Port LCSSA to the new PM

[Davide Italiano via llvm-commits]

davide added inline comments.

================
Comment at: lib/Transforms/Utils/LCSSA.cpp:345
@@ +344,3 @@
+  // ported to the new PM and the legacy LoopSimplify pass has a call to
+  // mustPreserveAnalysisID(LCSSAID) in its runOnFunction method. So, for now,
+  // we are not preserving LoopSimplify.
----------------
This is a sore point. I think mustPreserveAnalysisID(LCSSAID) should become an assert in the new PM which verifies that the IR mutation didn't destroy LCSSA.
In other words, mustPreserveAnalysisID(LCSSAID) might need to go away.


http://reviews.llvm.org/D21090