[llvm] r271925 - [MBP] Reduce code size by running tail merging in MBP.

Diana Picus via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 02:40:42 PDT 2016


On 8 June 2016 at 08:44,  <haicheng at codeaurora.org> wrote:
> I am not an expert of Thumb2 backend.  Is it a bug of the implementation of
> ReplaceTailWithBranchTo()?  Or BB#187 is mistakenly treated as an IT block
> (no t2IT instruction)?  Or I should not call tail merging after Block
> Placement for Thumb2 at all?

I'm not an expert either. I'll try to have a look, and I've also
created a bug for it: https://llvm.org/bugs/show_bug.cgi?id=28049
If anyone feels like they have a better chance of fixing this, please
go ahead :)

> I think Thumb2 cares the code size and my patch is beneficial to Thumb2.
> Please let me know what you think.

I think we should try to get it to work.

Diana


More information about the llvm-commits mailing list