[PATCH] D21107: Generate codeview for array types

[David Majnemer via llvm-commits]

majnemer added inline comments.

================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:785
@@ +784,3 @@
+  TypeIndex IndexType = Asm->MAI->getPointerSize() == 8 ?
+      TypeIndex(SimpleTypeKind::UInt64) :
+      TypeIndex(SimpleTypeKind::UInt32);
----------------
amccarth wrote:
> majnemer wrote:
> > They don't use UInt64Quad? Surprising.
> That's an excellent question.  Let me check it out.
x64 MSVC 2015 Update 2 says:
  Index type = T_UQUAD(0023)

x86 MSVC 2015 Update 2 says:
  Index type = T_ULONG(0022)

Sounds like we should use UInt32Long and UInt64Quad.


http://reviews.llvm.org/D21107