[polly] r271889 - [NFC] Simplify code

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 7 09:39:42 PDT 2016


On 06/06/2016 02:13 PM, Johannes Doerfert via llvm-commits wrote:
> Author: jdoerfert
> Date: Mon Jun  6 07:13:24 2016
> New Revision: 271889
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=271889&view=rev
> Log:
> [NFC] Simplify code
> 
> Modified:
>     polly/trunk/lib/CodeGen/CodeGeneration.cpp
> 
> Modified: polly/trunk/lib/CodeGen/CodeGeneration.cpp
> URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/CodeGeneration.cpp?rev=271889&r1=271888&r2=271889&view=diff
> ==============================================================================
> --- polly/trunk/lib/CodeGen/CodeGeneration.cpp (original)
> +++ polly/trunk/lib/CodeGen/CodeGeneration.cpp Mon Jun  6 07:13:24 2016
> @@ -208,13 +208,13 @@ public:
>        fixRegionInfo(EnteringBB->getParent(), R->getParent());
>      }
>  
> -    verifyGeneratedFunction(S, *EnteringBB->getParent());
> +    Function *F = EnteringBB->getParent();
> +    verifyGeneratedFunction(S, *F);
>      for (auto *SubF : NodeBuilder.getParallelSubfunctions())
>        verifyGeneratedFunction(S, *SubF);
>  
>      // Mark the function such that we run additional cleanup passes on this
>      // function (e.g. mem2reg to rediscover phi nodes).
> -    Function *F = EnteringBB->getParent();

Very nice! I really like these independent small changes. This really
makes reviewing your code easy.

Best,
Tobias


More information about the llvm-commits mailing list