[PATCH] D20443: [PowerPC] - Combine loads of v4i8 to loads of i32 followed by bitcast

Nemanja Ivanovic via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 7 07:21:36 PDT 2016


nemanjai added inline comments.

================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:10302
@@ +10301,3 @@
+     !isa<ConstantSDNode>(Ext1.getOperand(1)) ||
+     !isa<ConstantSDNode>(Ext2.getOperand(1)))
+    return SDValue();
----------------
If there are no further requests, I won't post another review for this, but the final patch will do away with these "isa" calls and replace them with dyn_cast calls and the corresponding getConstantOperandVal() calls will be replaced with getZExtValue() calls on the resulting ConstantSDNode's.


Repository:
  rL LLVM

http://reviews.llvm.org/D20443





More information about the llvm-commits mailing list