Re: [PATCH] D17268: [LAA] Function 'isStridedPtr' returns additional result “Loop *Lp” via function argument and add appropriate checks out of the 'isStridedPtr'.

Adam Nemet via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 7 04:03:12 PDT 2016


anemet accepted this revision.
anemet added a comment.
This revision is now accepted and ready to land.

LGTM with the improved comments in the testcases.  Thanks!


================
Comment at: test/Analysis/LoopAccessAnalysis/multiple-strides-rt-memory-checks.ll:1-2
@@ +1,3 @@
+; This is the test case from PR26314.
+; RUN: opt -loop-accesses -analyze -S < %s | FileCheck %s
+; CHECK: function 'Test':
----------------
Can you please add a bit more explanation here and in the other testcase.

Please include the C version and a few words like:

```
When we were retrying dependence checking with memchecks only, the loop-invariant access in the inner loop was incorrectly determined to be wrapping because it was not strided in the inner loop.
```


http://reviews.llvm.org/D17268





More information about the llvm-commits mailing list