[PATCH] D20560: [new PM] port LoopAccessAnalysis to new pass manager (part-1)

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 23:42:20 PDT 2016

chandlerc added a comment.

In http://reviews.llvm.org/D20560#450653, @davidxl wrote:

> Addressed review comments: do not rename existing header file and minimizes diffs.

I'm not sure what is expected to be changing here? There are four things in your patch description, and my suggestion was to split them apart. It looks like this isn't split apart, just adjusted?

I'm also not sure why you're adding the file to LoopAccessInfoAnalysis.h?

Maybe it would help to provide an updated over-all summary? I feel like I may just not understand what is going on here.


More information about the llvm-commits mailing list