[PATCH] D21049: [LibFuzzer] Fix some unit test crashes on OSX.

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 23:24:50 PDT 2016


delcypher added a comment.

In http://reviews.llvm.org/D21049#450598, @kcc wrote:

> The problem with linking asan + no-asan is this: 
>  https://github.com/google/sanitizers/wiki/AddressSanitizerContainerOverflow#false-positives
>
> I am not aware of any other issue caused by linking asan and no-asan together. 
>  Before fixing this problem I will need to understand it more. 
>  And it is very unlikely that the correct fix is in cmake. 
>  Remember -- the majority of the users are not going to build libFuzzer with cmake
>  and thus we should not be fixing bugs in cmake, unless they are test-specific.


I think this bug is specific to the unittests. The unittests are calling into libFuzzer internals that use C++ standard library types in their interface. The public facing functions (`LLVMFuzzerTestOneInput`, `LLVMFuzzerInitialize`, and `LLVMFuzzerCustomMutator`) do not as they use plain C types.


http://reviews.llvm.org/D21049





More information about the llvm-commits mailing list