[PATCH] D20769: [IPRA] Interprocedural Register Allocation - Analysis Passes

Vivek Pandya via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 23:17:31 PDT 2016


vivekvpandya added inline comments.

================
Comment at: lib/CodeGen/RegUsageInfoCollector.cpp:130
@@ +129,3 @@
+
+  PRUI->storeUpdateRegUsageInfo(Mdl->getNamedGlobal(MF.getName()),
+                                std::move(RegMask));
----------------
mehdi_amini wrote:
> This is not the right API: `getNamedGlobal` is for global *variables*, not function.
I tried out 

```
PRUI->storeUpdateRegUsageInfo(Mdl->getGlobalVariable(MF.getFunction()->getName(),true), std::move(RegMask));
```
and 

```
PRUI->storeUpdateRegUsageInfo(Mdl->getGlobalVariable(MF.getFunction()->getName()), std::move(RegMask));
```
but both returns nullptr for some functions.


http://reviews.llvm.org/D20769





More information about the llvm-commits mailing list