[PATCH] D20977: [LibFuzzer] Split the fuzzer-oom.test into two tests.

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 18:19:34 PDT 2016


kcc added inline comments.

================
Comment at: lib/Fuzzer/test/fuzzer-oom-darwin.test:1
@@ +1,2 @@
+REQUIRES: darwin
+RUN: not LLVMFuzzer-OutOfMemoryTest -rss_limit_mb=10 2>&1 | FileCheck %s
----------------
delcypher wrote:
> kcc wrote:
> > Why does this require darwin? 
> Technically it doesn't but my assumption is this would be the test for darwin (e.g. OSX). Do you want me to remove the `REQUIRES: darwin` line and remove darwin from the name of the test?
Yes, and yes. 
And remove linux from the other test's name (call it e.g. "oom-wit-profile")

================
Comment at: lib/Fuzzer/test/lit.cfg:31
@@ +30,3 @@
+hostPlatform = None
+if sys.platform == 'darwin':
+  hostPlatform = 'darwin'
----------------
And you will not need parts about darwin here


http://reviews.llvm.org/D20977





More information about the llvm-commits mailing list