[llvm] r271964 - Try one more time to pacify -Wpessimizing-move, MSVC, libstdc++4.7, and the world without a named variable

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 16:46:14 PDT 2016


Author: rnk
Date: Mon Jun  6 18:46:14 2016
New Revision: 271964

URL: http://llvm.org/viewvc/llvm-project?rev=271964&view=rev
Log:
Try one more time to pacify -Wpessimizing-move, MSVC, libstdc++4.7, and the world without a named variable

Modified:
    llvm/trunk/lib/DebugInfo/Symbolize/Symbolize.cpp

Modified: llvm/trunk/lib/DebugInfo/Symbolize/Symbolize.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/Symbolize/Symbolize.cpp?rev=271964&r1=271963&r2=271964&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/Symbolize/Symbolize.cpp (original)
+++ llvm/trunk/lib/DebugInfo/Symbolize/Symbolize.cpp Mon Jun  6 18:46:14 2016
@@ -325,8 +325,7 @@ LLVMSymbolizer::getOrCreateObject(const
   if (I == BinaryForPath.end()) {
     Expected<OwningBinary<Binary>> BinOrErr = createBinary(Path);
     if (!BinOrErr) {
-      OwningBinary<Binary> NullBinary;
-      BinaryForPath.insert(std::make_pair(Path, std::move(NullBinary)));
+      BinaryForPath.insert(std::make_pair(Path, OwningBinary<Binary>()));
       return BinOrErr.takeError();
     }
     Bin = BinOrErr->getBinary();




More information about the llvm-commits mailing list