[llvm] r271727 - Fix non-Windows build when inserting a move only type into a map

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 16:35:06 PDT 2016


Does r271958 fix it?

On Mon, Jun 6, 2016 at 3:20 PM, Richard Smith <richard at metafoo.co.uk> wrote:

> Stage 1 of one of the modules bootstrap buildbots has been red since this
> landed:
>
>
> http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules-2/builds/737/steps/compile/logs/stdio
>
> The version of libstdc++ in use on that bot (4.7.2) is a little old, but I
> believe we do still support it, so this should probably be changed to avoid
> using map::emplace.
>
> On Fri, Jun 3, 2016 at 1:29 PM, Reid Kleckner via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Author: rnk
>> Date: Fri Jun  3 15:29:51 2016
>> New Revision: 271727
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=271727&view=rev
>> Log:
>> Fix non-Windows build when inserting a move only type into a map
>>
>> Modified:
>>     llvm/trunk/lib/DebugInfo/Symbolize/Symbolize.cpp
>>
>> Modified: llvm/trunk/lib/DebugInfo/Symbolize/Symbolize.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/Symbolize/Symbolize.cpp?rev=271727&r1=271726&r2=271727&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/lib/DebugInfo/Symbolize/Symbolize.cpp (original)
>> +++ llvm/trunk/lib/DebugInfo/Symbolize/Symbolize.cpp Fri Jun  3 15:29:51
>> 2016
>> @@ -325,7 +325,7 @@ LLVMSymbolizer::getOrCreateObject(const
>>    if (I == BinaryForPath.end()) {
>>      Expected<OwningBinary<Binary>> BinOrErr = createBinary(Path);
>>      if (!BinOrErr) {
>> -      BinaryForPath.insert({Path, OwningBinary<Binary>()});
>> +      BinaryForPath.emplace(Path, OwningBinary<Binary>());
>>        return BinOrErr.takeError();
>>      }
>>      Bin = BinOrErr->getBinary();
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160606/723fa44b/attachment.html>


More information about the llvm-commits mailing list