[PATCH] D21042: Verifier: Simplify and fix issue where we were not verifying unmaterialized functions.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 16:04:26 PDT 2016


pcc added inline comments.

================
Comment at: lib/IR/Verifier.cpp:4481
@@ +4480,3 @@
+      if (F.isDeclaration())
+        HasErrors |= !V.verify(F);
+
----------------
aprantl wrote:
> Can you remind me why this change is only necessary in the LegacyPass implementation?
The LegacyPass implementation is the only one that calls `verify(Function &)` and `verify(Module &)` directly. The new pass manager uses the `verifyModule` and `verifyFunction` functions.


http://reviews.llvm.org/D21042





More information about the llvm-commits mailing list