[PATCH] D20999: [pdbdump] Print out New FPO stream contents.

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 10:08:27 PDT 2016


It checks that there is enough space for the requested number of elements
in the underlying stream, but it doesn't check that the stream length is
exactly the right length because it doesn't know if there is more data
after the array
On Mon, Jun 6, 2016 at 10:01 AM David Majnemer <david.majnemer at gmail.com>
wrote:

> majnemer added inline comments.
>
> ================
> Comment at: lib/DebugInfo/PDB/Raw/DbiStream.cpp:313-314
> @@ +312,4 @@
> +
> +  size_t StreamLen = FpoStream->getLength();
> +  size_t NumRecords = StreamLen / sizeof(object::FpoData);
> +  codeview::StreamReader Reader(*FpoStream);
> ----------------
> I don't see such a check.
>
>
> http://reviews.llvm.org/D20999
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160606/6c93d831/attachment.html>


More information about the llvm-commits mailing list