[PATCH] D20084: [sanitizer] Initial implementation of a Hardened Allocator

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 09:29:51 PDT 2016


kcc added a comment.

> We do check for SSE 4.2 in the init of the Allocator via CHECK(testCPUFeature(SSE4_2))


That's not enough. 
This is a run-time check and so if someone runs "check-all" on a machine that does not support SSE4_2
thye *will* run check-scudo and get a test failure. 
Instead, we need to ensure that check-scudo is not executed as part of check-all when there is no proper HW support

And of course, fix check-scudo on my machine [ :) ] so that I can test it before committing.


http://reviews.llvm.org/D20084





More information about the llvm-commits mailing list