[PATCH] D21017: [asan] Reenable ASan tests in "check-all"

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 04:57:48 PDT 2016


kubabrecka created this revision.
kubabrecka added reviewers: wang0109, rnk, etienneb, dvyukov, samsonov, glider, kcc.
kubabrecka added subscribers: llvm-commits, zaks.anna.
kubabrecka added a project: Sanitizers.
Herald added a subscriber: kubabrecka.

Somehow, in r271049, ASan lit tests and unit tests were removed from “check-all”.  Doesn’t seem intentional, let’s fix it.

http://reviews.llvm.org/D21017

Files:
  test/asan/CMakeLists.txt

Index: test/asan/CMakeLists.txt
===================================================================
--- test/asan/CMakeLists.txt
+++ test/asan/CMakeLists.txt
@@ -5,7 +5,7 @@
 
 # TODO(wwchrome): Re-enable Win64 asan tests when ready.
 # Disable tests for asan Win64 temporarily.
-if(NOT OS_NAME MATCHES "Windows" OR CMAKE_SIZEOF_VOID_P EQUAL 8)
+if(OS_NAME MATCHES "Windows" AND CMAKE_SIZEOF_VOID_P EQUAL 8)
   set(EXCLUDE_FROM_ALL TRUE)
 endif()
 
@@ -124,6 +124,6 @@
 endif()
 
 # TODO(wwchrome): Re-enable the tests for asan Win64 when ready.
-if(NOT OS_NAME MATCHES "Windows" OR CMAKE_SIZEOF_VOID_P EQUAL 8)
+if(OS_NAME MATCHES "Windows" AND CMAKE_SIZEOF_VOID_P EQUAL 8)
   set(EXCLUDE_FROM_ALL FALSE)
 endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21017.59705.patch
Type: text/x-patch
Size: 715 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160606/d76e8847/attachment.bin>


More information about the llvm-commits mailing list