[PATCH] D21010: Replace the implementation of ConstantRange::binaryAnd.

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 5 22:53:56 PDT 2016


sanjoy added a comment.

Hi Nick,

I haven't read the code yet (will do that soon), but I wonder if you've tried the following approach: map a `ConstantRange` to `KnownOne` and `KnownZero`, use these to compute the binary and, and map the resultant `KnownOne` and `KnownZero` back to a `ConstantRange`.  That will probably not be easier in terms of code, but will make the code organization more obvious, and most of the interesting logic can be re-used for `binaryOr`.


http://reviews.llvm.org/D21010





More information about the llvm-commits mailing list