[PATCH] D20999: [pdbdump] Print out New FPO stream contents.

[David Majnemer via llvm-commits]

majnemer added a subscriber: majnemer.

================
Comment at: lib/DebugInfo/PDB/Raw/DbiStream.cpp:313-314
@@ +312,4 @@
+
+  size_t StreamLen = FpoStream->getLength();
+  size_t NumRecords = StreamLen / sizeof(FpoData);
+  codeview::StreamReader Reader(*FpoStream);
----------------
Should we check that StreamLen is a multiple of sizeof(FpoData)?

================
Comment at: tools/llvm-pdbdump/LLVMOutputStyle.cpp:691-692
@@ +690,4 @@
+    P.printNumber("Number of Saved Registers", Fpo.getNumSavedRegs());
+    P.printNumber("Has SEH", Fpo.hasSEH());
+    P.printNumber("Use BP", Fpo.useBP());
+    P.printNumber("Frame Pointer", Fpo.getFP());
----------------
Shouldn't these be printed as booleans?


http://reviews.llvm.org/D20999