[PATCH] D20977: [LibFuzzer] Fix fuzzer-oom.test on OSX.

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 3 19:06:03 PDT 2016


delcypher added a comment.

In http://reviews.llvm.org/D20977#448818, @kcc wrote:

> Interesting solution! 
>  But wrong. :(


I had a feeling you'd say that. This patch does feel like a massive hack.

> Essentially, you are now not testing that the heap profile is printed, but that libFuzzer successfully bypasses the test. 

>  Instead of this, I suggest to make two copies of test/fuzzer-oom.test. 

>  One will remain as is and require linux. 

>  Another one will work on darwing too, but will not check for "Live Heap Allocations:"


That's essentially what I mentioned in the patch summary (`In the future if we want to better test information about the live
heap allocations..`) as something we should do so I'm happy to make the change you suggest.


http://reviews.llvm.org/D20977





More information about the llvm-commits mailing list