[PATCH] D20547: [safestack] Sink unsafe address computation to each use.

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 3 14:25:18 PDT 2016


eugenis added inline comments.

================
Comment at: lib/CodeGen/SafeStack.cpp:615
@@ +614,3 @@
+    std::string Name = std::string(AI->getName()) + ".unsafe";
+    while (!AI->use_empty()) {
+      Use &U = *AI->use_begin();
----------------
Removed.

================
Comment at: lib/CodeGen/SafeStack.cpp:638
@@ -625,3 +637,3 @@
   StaticOffset = alignTo(StaticOffset, StackAlignment);
 
   // Update shadow stack pointer in the function epilogue.
----------------
Fixed in D20986.


Repository:
  rL LLVM

http://reviews.llvm.org/D20547





More information about the llvm-commits mailing list