[PATCH] D17257: New utility class ReachingPhysDefs for post-ra analysis.

[Quentin Colombet via llvm-commits]

qcolombet added a comment.

Hi Jonas,

Thanks for the update.

> First I wonder if there is any progress on deciding if ReachingPhysDefs or the RDF should go in?


Given that ReachingPhysDefs is already working for other client thanks to your work, I would pursue with pushing it out.
Then, we can push RDF as a replacement when all that work is done.

Couple of comments.

Cheers,
-Quentin


================
Comment at: lib/Target/AArch64/AArch64CollectLOH.cpp:127
@@ -125,3 +126,3 @@
 
-#define DEBUG_TYPE "aarch64-collect-loh"
+#define DEBUG_TYPE "reachingdefs"
 
----------------
Actually, I’ve found that this is already possible.
One has to separate the passes name with a comma.
E.g.,  -debug-only=isel,machine-licm

In other words, please do not change that debug type :).

================
Comment at: lib/Target/AArch64/AArch64CollectLOH.cpp:532
@@ -703,3 +531,3 @@
 
-  const MachineInstr *Def = *UseToDefs.find(Instr)->second.begin();
+  MachineInstr *Def = *UseToDefs.find(Instr)->second.begin();
   if (Def->getOpcode() != AArch64::ADRP) {
----------------
What I was saying is even if the UseToDefs structure hold non-const refs (which is fine), this particular use could remain const without impacting other clients, right?


http://reviews.llvm.org/D17257