[PATCH] D17573: [X86] PR26554: Use not all set of alternative nops in 64 bit mode, but only those which are correct

Bruno Cardoso Lopes via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 3 11:07:17 PDT 2016


bruno added subscribers: echristo, ahatanak.

================
Comment at: include/llvm/Support/TargetRegistry.h:116
@@ -115,2 +115,3 @@
   typedef MCAsmBackend *(*MCAsmBackendCtorTy)(const Target &T,
+                                              const MCSubtargetInfo &STI,
                                               const MCRegisterInfo &MRI,
----------------
I'm not sure about threading this around would yield any unwanted dependency. @Akira and @Eric, is this a problem?

================
Comment at: lib/Target/X86/X86.td:42
@@ -37,1 +41,3 @@
+                                       "Long nops larger than 7 are slow">;
+
 def FeatureCMOV    : SubtargetFeature<"cmov","HasCMov", "true",
----------------
These should be two distinct commits/patches, one for FeatureLongNop and another for FeatureFastNop7.


http://reviews.llvm.org/D17573





More information about the llvm-commits mailing list