[PATCH] D20670: [tsan] On OS X, build Go runtime with -mmacosx-version-min

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 3 06:57:08 PDT 2016


kubabrecka added a comment.

In http://reviews.llvm.org/D20670#448152, @dvyukov wrote:

> It's a single .o file (renamed to .syso).


I see.  In that case the Go compiler should already be passing *some* -mmacosx-version-min to the linker.  If it isn’t then the resulting program will inherit your system OS version as the minimum supported OS X.  Anyway, this is either a non-issue (Go compiler is already passing the correct flags) or the issue is not TSan-specific (Go compiler doesn’t set -mmacosx-version-min, all resulting binaries can only run on your system and newer).


http://reviews.llvm.org/D20670





More information about the llvm-commits mailing list