[PATCH] D20912: [Polly][GSoC 2016]Update ScopBuilder's memory management

Utpal Bora via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 3 06:32:52 PDT 2016


cs14mtech11017 added inline comments.

================
Comment at: lib/Analysis/ScopInfo.cpp:4901
@@ +4900,3 @@
+  ScopBuilder *SB;
+  SB = new ScopBuilder(R, AC, AA, DL, DT, LI, SD, SE);
+  if (SB) {
----------------
jdoerfert wrote:
> Why allocate the ScopBuilder on the heap anyway?
> Doesn't this work:
> 
> ```
>  ScopBuilder SB(R, AC, AA, DL, DT, LI, SD, SE);
> ```
> 
Yes this would be even better. Thanks.


http://reviews.llvm.org/D20912





More information about the llvm-commits mailing list