[PATCH] D20937: [cpu-detection] Naming convention.

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 22:10:08 PDT 2016


Sweet thanks! :)

On Thu, Jun 2, 2016, 9:47 PM Alina Sbirlea <asbirlea at google.com> wrote:

> Got it. I'll redo the patch.
> On Jun 2, 2016 7:04 PM, "Eric Christopher" <echristo at gmail.com> wrote:
>
>> To elaborate a bit here: what's happening is that the update the list
>> sees is that you added the list and some reviewers, rather than an initial
>> email that contains the patch and your description of it so that people can
>> scan and look at patches without needing to go to phabricator.
>>
>> On Thu, Jun 2, 2016, 6:57 PM Eric Christopher via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>>
>>> echristo added a comment.
>>>
>>> Can you abandon this revision and start again while remembering to add
>>> llvm-commits as you create the review please? Makes it much easier to
>>> make
>>> sure everyone sees the mails.
>>>
>>> Thanks!
>>>
>>>
>>> http://reviews.llvm.org/D20937
>>>
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160603/ff3afe82/attachment.html>


More information about the llvm-commits mailing list