[PATCH] D20936: [pdb] Parse module line info

[David Majnemer via llvm-commits]

majnemer added inline comments.

================
Comment at: tools/llvm-pdbdump/llvm-pdbdump.cpp:545
@@ +544,3 @@
+                  P.printNumber("Offset", N.Offset);
+                  P.printNumber("StartLine", LI.getStartLine());
+                  P.printNumber("EndDelta", LI.getLineDelta());
----------------
I'd use the logic in tools/llvm-readobj/COFFDumper.cpp:940:
```
        if (LI.isAlwaysStepInto())
          W.printString("StepInto", StringRef("Always"));
        else if (LI.isNeverStepInto())
          W.printString("StepInto", StringRef("Never"));
        else
          W.printNumber("LineNumberStart", LI.getStartLine());
```

You might have to update fewer tests down the road if you choose the same output format that llvm-readobj uses.


http://reviews.llvm.org/D20936