[PATCH] D20833: [esan|wset] Add 8-level working set snapshot accumulation

[Derek Bruening via llvm-commits]

bruening marked 3 inline comments as done.

================
Comment at: lib/esan/esan_flags.inc:44
@@ +43,3 @@
+// This controls the difference in frequency between each successive series
+// of snapshots.  There are 8 in total, with number 0 using -sample_freq.
+// Number N samples number N-1 every (1 << -snapshot_step) instance of N-1.
----------------
aizatsky wrote:
> Why do you use negated values here?
The dash is supposed to indicate an option.  I will remove it (esp since sanitizer options don't use dash prefixes).

================
Comment at: lib/esan/working_set.cpp:196
@@ +195,3 @@
+
+static u32 getFrequencyForPrinting(u32 MilliSec, const char *&Unit) {
+  if (MilliSec > 600000) {
----------------
aizatsky wrote:
> This is not frequency, this is period, right? Frequency is in hz.
Right.


http://reviews.llvm.org/D20833