[PATCH] D20751: [esan] Add sideline itimer support

Mike Aizatsky via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 14:00:03 PDT 2016


aizatsky added inline comments.

================
Comment at: lib/esan/esan_sideline_linux.cpp:49
@@ +48,3 @@
+      return;
+    Thread->sampleFunc(Thread->FuncArg);
+  } else
----------------
I think you should add overrun detection in case your function is slow from day 1.
You would get very unreliable results if you hit this, and it would be hard to tell why,


http://reviews.llvm.org/D20751





More information about the llvm-commits mailing list