[PATCH] D20833: [esan|wset] Add 8-level working set snapshot accumulation

[Mike Aizatsky via llvm-commits]

aizatsky added inline comments.

================
Comment at: lib/esan/esan_flags.inc:44
@@ +43,3 @@
+// This controls the difference in frequency between each successive series
+// of snapshots.  There are 8 in total, with number 0 using -sample_freq.
+// Number N samples number N-1 every (1 << -snapshot_step) instance of N-1.
----------------
Why do you use negated values here?

================
Comment at: lib/esan/working_set.cpp:196
@@ +195,3 @@
+
+static u32 getFrequencyForPrinting(u32 MilliSec, const char *&Unit) {
+  if (MilliSec > 600000) {
----------------
This is not frequency, this is period, right? Frequency is in hz.

================
Comment at: lib/esan/working_set.cpp:234
@@ +233,3 @@
+      u32 Time = getFrequencyForPrinting(getFlags()->sample_freq*Freq, Unit);
+      Report(" Samples array #%d at frequency %u %s\n", i, Time, Unit);
+      // FIXME: report whether we wrapped around and thus whether we
----------------
period


http://reviews.llvm.org/D20833