[PATCH] D20897: [AVX512/AVX][Intrinsics] Fix Variable Bit Shift Right Arithmetic intrinsic lowering.

Igor Breger via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 13:11:02 PDT 2016


igorb added a comment.

In http://reviews.llvm.org/D20897#447281, @RKSimon wrote:

> I just think we're better off handling simplification of intrinsics as early as possible - in this case in InstCombiner::visitCallInst instead of waiting until lowering.
>
> Also, should we be adding constant folding (or other optimizations) to LowerINTRINSIC_WO_CHAIN ? I understood that is for cleanup + canonicalization only.


In this case constant folding done before intrinsic simplification only in order to match intrinsic behavior so general  ISD::SRA can be used.


Repository:
  rL LLVM

http://reviews.llvm.org/D20897





More information about the llvm-commits mailing list