[PATCH] D19271: Change CALL_ONCE_INITIALIZATION implementation to use static initialization

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 01:40:56 PDT 2016


chandlerc added a subscriber: chandlerc.
chandlerc added a comment.

Mehdi, your patch used generic code for the non-'std::call_once' path. How about re-committing, but rather than putting it behind an Windows ifdef, instead just put it behind an "else". Then you can change the guard for using the std variant to just exclude NetBSD until the fix lands. That lets all other platforms make forward progress (including allowing Reid to work on a more reliable Windows-specific implementation if desired).

(I have the same motivation as you I suspect -- my TSan users are complaining. =])


http://reviews.llvm.org/D19271





More information about the llvm-commits mailing list