[PATCH] D20741: [LibFuzzer] Reimplement how the optional user functions are called.

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 1 18:11:03 PDT 2016


delcypher marked 5 inline comments as done.

================
Comment at: lib/Fuzzer/FuzzerExtFunctions.h:27
@@ +26,3 @@
+
+#include "FuzzerExtFunctions.def"
+
----------------
I've done this. One place where there is technically still duplication is in `FuzzerExtFunctionsWeak.cpp` with the declaration of the weak functions but I'd rather leave that how it is currently because I don't want too much macro magic.

================
Comment at: lib/Fuzzer/FuzzerExtFunctionsDlsym.cpp:16
@@ +15,3 @@
+#if LIBFUZZER_APPLE
+
+#include "FuzzerExtFunctions.h"
----------------
In interest of a simple implementation I'm sticking with the `LIBFUZZER_APPLE` and `LIBFUZZER_LINUX` for now. We can revisit this in the future if it really becomes a problem.


http://reviews.llvm.org/D20741





More information about the llvm-commits mailing list