[llvm] r271442 - cmake: Fix color diags under ninja if the compiler is "AppleClang"

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 1 16:29:26 PDT 2016


Author: bogner
Date: Wed Jun  1 18:29:26 2016
New Revision: 271442

URL: http://llvm.org/viewvc/llvm-project?rev=271442&view=rev
Log:
cmake: Fix color diags under ninja if the compiler is "AppleClang"

Apparently cmake differentiates between Clang and AppleClang, and we
fail to color our diagnostics if you have the latter. Fix that.

Modified:
    llvm/trunk/cmake/modules/HandleLLVMOptions.cmake

Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=271442&r1=271441&r2=271442&view=diff
==============================================================================
--- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)
+++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Wed Jun  1 18:29:26 2016
@@ -559,7 +559,7 @@ add_llvm_definitions( -D__STDC_LIMIT_MAC
 
 # clang doesn't print colored diagnostics when invoked from Ninja
 if (UNIX AND
-    CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND
+    CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND
     CMAKE_GENERATOR STREQUAL "Ninja")
   append("-fcolor-diagnostics" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
 endif()




More information about the llvm-commits mailing list