[PATCH] D20831: [Polly][GSoC]Renamed ScopInfo to ScopBuilder and update its memory management.

Johannes Doerfert via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 1 16:31:36 PDT 2016


Hey Michael,

thank you for looking into this.

> Meinersbur added a comment.
> This revision now requires changes to proceed.
> 
> Can you make two commits, one for
> "Rename ScopInfo to ScopBuilder."
> and another
> "Update ScopBuilder's memory management."?
I agree.

> In a later step, we could move the ScopBuilder into its own ScopBuilder.cpp and remove its declaration from the public ScopInfo.h as it's only used by ScopInfoRegionPass.
I think this should be done by you Michael as you rewrote the most of
that code last. That way git-blame will still have some meaning.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: Digital signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160602/93cbe999/attachment.sig>


More information about the llvm-commits mailing list