[PATCH] D17898: Implement expansion of {s, u}{min, max} in integer legalization

[Ahmed Bougacha via llvm-commits]

ab added a subscriber: ab.
ab added a comment.

I can't comment on the test changes, but the code LGTM.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:1671
@@ -1665,1 +1670,3 @@
 
+static ISD::CondCode getMinMaxOps(unsigned int Op, ISD::NodeType &LoOp) {
+
----------------
Maybe go even further and return a std::pair, and std::tie it into LoOpc/CondC ?

Also, maybe make it more explicit by calling it, say, "getExpandedMinMaxOps", and/or adding a comment.

================
Comment at: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:1684
@@ +1683,3 @@
+                                           SDValue &Lo, SDValue &Hi) {
+  SDLoc dl(N);
+  ISD::NodeType LoOpc;
----------------
dl -> DL


Repository:
  rL LLVM

http://reviews.llvm.org/D17898