[PATCH] D20762: AArch64: Do not test for CPUs, use SubtargetFeatures

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 1 11:16:04 PDT 2016


MatzeB marked 2 inline comments as done.

================
Comment at: lib/Target/AArch64/AArch64Subtarget.cpp:69
@@ +68,3 @@
+    break;
+  case ExynosM1:
+  case Kryo:
----------------
mssimpso wrote:
> Hi Matthias,
> 
> I haven't yet looked at this patch in much detail. But would you mind double checking the Exynos properties before committing this change? I didn't think Exynos and Kryo shared these value. Shouldn't MaxInterleaveFactor = 2 and VectorInsertExtractBaseCost = 3 for Exynos? The Kryo numbers look correct. Perhaps there's a missing "break" here?
Indeed there are too many fallthroughs happening here, I'll double check this switch and update the diff here.


Repository:
  rL LLVM

http://reviews.llvm.org/D20762





More information about the llvm-commits mailing list