[PATCH] D20793: [ELF] - Implemented support for test/binop relaxations from latest ABI.

[George Rimar via llvm-commits]

grimar added a comment.

In http://reviews.llvm.org/D20793#445826, @rafael wrote:

> LGTM with nits


Thanks for review !
r271405 and waiting for buildbot results, just in case.


================
Comment at: ELF/Target.cpp:759
@@ +758,3 @@
+  // they are 32bit operations and not common to have.
+  return (!Config->Pic && Type == R_X86_64_REX_GOTPCRELX) ? R_RELAX_GOT_PC_NOPIC
+                                                          : RelExpr;
----------------
rafael wrote:
> You can drop the Type == R_X86_64_REX_GOTPCRELX making this just
> 
> return Config->Pic ? RelExpl : R_RELAX_GOT_PC_NOPIC;
> 
> no?
Yes. I placed assert there instead to make clear what we expect.
Since we don't have testcase part for 32x instructions anymore, and llvm-mc
generating slightly different result from gas, I think it is reasonable.


Repository:
  rL LLVM

http://reviews.llvm.org/D20793