[PATCH] D20220: [PEI, AArch64] Use empty spaces in stack area for local stack slot allocation.

Gerolf Hoflehner via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 18:59:51 PDT 2016


> On May 27, 2016, at 4:16 PM, Gerolf Hoflehner <ghoflehner at apple.com> wrote:
> 
> Gerolf added a comment.
> 
> Thanks, Geoff. I take back my previous comment. I was worried that when A and B are allocated  at stack offset x and this optimization changes x, it would only change it for A but not for B. But looking deeper into the code this is not the case.
> 
> 
> ================
> Comment at: lib/CodeGen/PrologEpilogInserter.cpp:632
> @@ +631,3 @@
> +    // clear it to speed up later scavengeStackSlot calls to
> +    // StackBytesFree.none()
> +    StackBytesFree.clear();
> ----------------
> gberry wrote:
>> I suppose, but I don't think it would make the loop any clearer since I don't think it would simplify the control flow of the loop.  Also, this function isn't really doing much else.
> I agree with your functionality argument. A function would just improve readability.

Just to clarify: this is for readability and should not block your commit. :-)
> 
> 
> http://reviews.llvm.org/D20220
> 
> 
> 



More information about the llvm-commits mailing list