[PATCH] D20847: BitCast infinite loop fix

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 18:56:41 PDT 2016


hfinkel added a subscriber: hfinkel.
hfinkel added a comment.

In http://reviews.llvm.org/D20847#445263, @majnemer wrote:

> This needs a testcase.
>
> Also, I find removing things from the worklist incredibly, deeply suspicious.  Otherwise the rest of InstCombine must be careful not to add the item to the list, no?


Could you please explain how this ends up looping? Are we recreating the same input over again?


Repository:
  rL LLVM

http://reviews.llvm.org/D20847





More information about the llvm-commits mailing list