[PATCH] D20346: [stack-protection] Add support for MSVC buffer security check

[David Majnemer via llvm-commits]

majnemer added a comment.

In http://reviews.llvm.org/D20346#440161, @rnk wrote:

> In http://reviews.llvm.org/D20346#439984, @majnemer wrote:
>
> > @rnk How does this play with WinEHPrepare, AsmPrinter and the state number insertion pass? Should those be updated later? Should we not enable /GS by default until they are implemented?
>
>
> Hm, maybe we should block stack guard insertion into functions with EH funclets for now. I think we have to update the tables and switch from _except_handler3 to _except_handler4 for SEH.


There are some upsides to transparently upgrading the personality in the backend: we'd support transparently support inlining between the two and other frontends would need similar changes.

> The general approach here should work, though. We don't need to do anything special for funclet prologue/epilogues because they never hold any address-taken stack objects. Those all live in the parent stack frame.





http://reviews.llvm.org/D20346