[PATCH] D20741: [LibFuzzer] Fix weak linking issues building tests under OSX.

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 13:59:17 PDT 2016


delcypher added a comment.

@kcc : I've uploaded a work in progress patch so you can take a look to see if I'm going in the right direction with this. One thing I'm not very happy about is `FuzzerMain.cpp`. The implementation of `main(int argc, char **argv)` needs to be able to optionally call `LLVMFuzzerInitialize` but also the `Fuzzer` class needs access to bunch of other functions. So currently they both independently create a `fuzzer::ExternalFunctions` and call `Init()`. This is wasteful but I wanted to avoid changing the interface of `fuzzer::fuzzerDriver` and the constructor of `Fuzzer` which would be required if I wanted to propagate `EF` through the layers into an instance of the `Fuzzer` class. Any thoughts on how you would like this handled?


http://reviews.llvm.org/D20741





More information about the llvm-commits mailing list