[PATCH] D20825: Don't force Python2.7

[Justin Bogner via llvm-commits]

Luke Drummond via llvm-commits <llvm-commits at lists.llvm.org> writes:
> ldrumm created this revision.
> ldrumm added subscribers: llvm-commits, zturner.
> ldrumm set the repository for this revision to rL LLVM.
>
> llvm's CMakeLists has a Special case to reject python versions != 2.7
> due to a dependency on that version by `lldb` that is no longer
> required.
>
> [224948](http://reviews.llvm.org/rL224948) was introduced to
> workaround this limitation in lldb. However it appears this is no
> needed, as lldb builds with python >= 2.7 since @zturner [made
> improvements to the lldb's cmake in
> 249466](http://reviews.llvm.org/rL249466), supporting python3 in
> lldb. Additionally, python 3.5 is required for Visual Studio 2015
> debug builds with python bindings, so the reasons for this limitation
> seem obsolete.
>
> I'm not sure whether there are other repercussions from disabling this
> check, so I'd appreciate comments with those more familiar with build
> system
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D20825
>
> Files:
>   CMakeLists.txt
>
> Index: CMakeLists.txt
> ===================================================================
> --- CMakeLists.txt
> +++ CMakeLists.txt
> @@ -450,10 +450,7 @@
>  
>  include(HandleLLVMOptions)
>  
> -# Verify that we can find a Python 2 interpreter.  Python 3 is unsupported.
> -# FIXME: We should support systems with only Python 3, but that requires work
> -# on LLDB.
> -set(Python_ADDITIONAL_VERSIONS 2.7)
> +# Verify that we can find a Python interpreter.

We should still check that you're using *at least* python 2.7, no? If
someone comes along with python 2.6 or something we'll want to reject
early rather than fail later.

>  include(FindPythonInterp)
>  if( NOT PYTHONINTERP_FOUND )
>    message(FATAL_ERROR
>
>
> Index: CMakeLists.txt
> ===================================================================
> --- CMakeLists.txt
> +++ CMakeLists.txt
> @@ -450,10 +450,7 @@
>  
>  include(HandleLLVMOptions)
>  
> -# Verify that we can find a Python 2 interpreter.  Python 3 is unsupported.
> -# FIXME: We should support systems with only Python 3, but that requires work
> -# on LLDB.
> -set(Python_ADDITIONAL_VERSIONS 2.7)
> +# Verify that we can find a Python interpreter.
>  include(FindPythonInterp)
>  if( NOT PYTHONINTERP_FOUND )
>    message(FATAL_ERROR
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits