[PATCH] D20783: [PM] Port IndVarSimplify to the new pass manager

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 10:58:08 PDT 2016


davide added a comment.

The general structure looks fine to me. I left a comment for something that we should take care of (but we can't yet).
Would love to get a second opinion on it.

Thanks!


================
Comment at: lib/Transforms/Scalar/IndVarSimplify.cpp:2238
@@ +2237,3 @@
+    return PreservedAnalyses::all();
+
+  return getLoopPassPreservedAnalyses();
----------------
The old PM 'preserves the CFG'. We can't do that yet in the new PM. Can you please add a FIXME here so we won't forget?


http://reviews.llvm.org/D20783





More information about the llvm-commits mailing list