[PATCH] D20708: Add ARM subtarget feature +long64

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 03:02:29 PDT 2016


rengolin added a comment.

In http://reviews.llvm.org/D20708#443944, @t.p.northover wrote:

> The only thing I know of that "long" could affect is the libcalls we produce, but as far as I'm aware the only dodgy cases are specified in terms of size_t and ptrdiff_t.
>
> Those types vary completely independently of "long" (on some platforms they're "long", on others "long long").


I commented on http://reviews.llvm.org/D20709 that this might be better as a proper ABI, but even in the case we don't do that, having this flag should be mostly harmless.

Users won't have a way to set it without calling CC1 directly, and if they do, than whatever lib calls they were expecting to work has to know about the new sizes/alignments.

cheers,
--renato


http://reviews.llvm.org/D20708





More information about the llvm-commits mailing list