[PATCH] D20708: Add ARM subtarget feature +long64

Kristof Beyls via llvm-commits llvm-commits at lists.llvm.org
Mon May 30 04:53:30 PDT 2016


kristof.beyls added a comment.

http://reviews.llvm.org/D20709 is where the review happens for the clang side of this patch.

See also my comments on that ticket.

When using the long-is-64-bits-abi-variant introduced in this patch, code generation must change. I think there should be tests for this as part of this patch.

I don't understand how this patch can change code generation. Did you forget to add some changes to this patch, or am I missing something?


http://reviews.llvm.org/D20708





More information about the llvm-commits mailing list