[PATCH] D20670: [tsan] On OS X, build Go runtime with -mmacosx-version-min

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Sat May 28 23:30:48 PDT 2016


dvyukov added inline comments.

================
Comment at: lib/tsan/CMakeLists.txt:129
@@ -128,3 +128,3 @@
   add_custom_target(GotsanRuntimeCheck
-    COMMAND env "CC=${CMAKE_C_COMPILER} ${OSX_SYSROOT_FLAG}"
+    COMMAND env "CC=${CMAKE_C_COMPILER} ${OSX_SYSROOT_FLAG} -mmacosx-version-min=${SANITIZER_MIN_OSX_VERSION}"
             IN_TMPDIR=1 SILENT=1 ${BUILDGO_SCRIPT}
----------------
Result of this invocation is discarded. buildgo.sh itself should produce valid object file. Add -mmacosx-version-min to buildgo.sh and set it to 10.7 -- that's the minimum supported Mac version for Go.



http://reviews.llvm.org/D20670





More information about the llvm-commits mailing list