[PATCH] D20752: [MC] Support symbolic expressions in assembly directives

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Fri May 27 17:13:44 PDT 2016

Cool, go for it.

Unless there is a substantial change in the patch I don't think you
need a second review.


On 27 May 2016 at 19:31, Petr Hosek <phosek at chromium.org> wrote:
> phosek updated this revision to Diff 58863.
> phosek added a comment.
> I've managed to replicate the failure in Release+Asserts build (I was using Debug previously) and I've fixed one other issue in the test, now all the tests should be passing (hopefully everywhere).
> Repository:
>   rL LLVM
> http://reviews.llvm.org/D20752
> Files:
>   include/llvm/MC/MCObjectStreamer.h
>   include/llvm/MC/MCStreamer.h
>   lib/MC/MCAsmStreamer.cpp
>   lib/MC/MCObjectStreamer.cpp
>   lib/MC/MCParser/AsmParser.cpp
>   lib/MC/MCStreamer.cpp
>   test/MC/AsmParser/directive_fill.s
>   test/MC/AsmParser/directive_space.s

More information about the llvm-commits mailing list